Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for cip-14.md #99

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Add test cases for cip-14.md #99

merged 6 commits into from
Mar 19, 2024

Conversation

womensrights
Copy link
Contributor

Overview

Add in test cases for cip-14

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

cips/cip-14.md Outdated Show resolved Hide resolved
cips/cip-14.md Outdated Show resolved Hide resolved
cips/cip-14.md Outdated Show resolved Hide resolved
cips/cip-14.md Outdated Show resolved Hide resolved
cips/cip-14.md Outdated Show resolved Hide resolved
cips/cip-14.md Outdated Show resolved Hide resolved
cips/cip-14.md Outdated Show resolved Hide resolved
cips/cip-14.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test cases + links! I left a few comments for the optional test cases

cips/cip-14.md Outdated Show resolved Hide resolved
cips/cip-14.md Outdated Show resolved Hide resolved
cips/cip-14.md Outdated Show resolved Hide resolved
womensrights and others added 3 commits March 19, 2024 11:36
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcstein jcstein merged commit 61924d1 into celestiaorg:main Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants