Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rootulp as CIP editor #98

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 12, 2024

Motivation

Anyone meeting the above requirements may make a pull request adding themselves as an CIP editor and adding themselves to the editor list in [CIP-1](./cip-1.md). If every existing CIP editor approves, the author becomes a full CIP editor. This should notify the editor of relevant new proposals submitted in the CIPs repository, and they should review and merge those pull requests.

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Rootul would be a great addition to the editor team. This is based on his past contributions as an informal editor on many of the CIP pull requests.

@jcstein
Copy link
Member

jcstein commented Mar 13, 2024

Would it be best to also modify the workflow in the PR, so in the case it is accepted, you can be added as a reviewer on PRs by the @celestia-bot ?

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproval for addition to auto_reviewers.yml

@YazzyYaz YazzyYaz merged commit f769423 into celestiaorg:main Mar 15, 2024
1 check passed
@rootulp rootulp deleted the patch-1 branch March 15, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants