Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cip-template.md with parameter section #97

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Conversation

ebuchman
Copy link
Collaborator

@ebuchman ebuchman commented Mar 7, 2024

Overview

Per the discussion on Dev Call 6 today, in order to make it easy to keep CIP-13 up-to-date, CIP's should include a parameter section that specifies any parameter changes.

I added it as a separate Parameters section but it could just as well go into the Specification section if that's preferred.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@ebuchman ebuchman marked this pull request as ready for review March 7, 2024 00:50
@celestia-bot celestia-bot requested review from jcstein and YazzyYaz March 7, 2024 00:50
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional change regarding column headings

cips/cip-template.md Outdated Show resolved Hide resolved
cips/cip-template.md Outdated Show resolved Hide resolved
cips/cip-template.md Outdated Show resolved Hide resolved
cips/cip-template.md Outdated Show resolved Hide resolved
@jcstein jcstein merged commit 0892ba7 into main Mar 14, 2024
1 check passed
@jcstein jcstein deleted the ebuchman-patch-1 branch September 17, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants