-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP: Support ZK-SNARKS in the Celestia Core #91
base: main
Are you sure you want to change the base?
Conversation
Initial Draft CIP 18
cips/cip-18.md
Outdated
|
||
3. BLS12-377 has the property of enabling effecient depth 1 recursions. This makes it a compelling choice for protocols that benefit from either privacy or aggregation of proofs. There is a also a wide range of tools available for this curve because of prior usage in protocols like Celo. | ||
|
||
4. GROTH16 has been in production since ZCash's sapling protocol. It represents the MVP of SNARK proof systems. It can also act as "universal adapter" for other proof systems because there circuits that verify other proof systems available. GROTH16 requires a two phase trusted setup. The first phase is universal for a given circuit size but the second phase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it also has the smallest proof size and lowest verification cost!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for drafting this CIP! I left a few formatting suggestions I observed while reading.
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Changing this to CIP-19 as #77 is CIP-18 |
@zmanian can you please change the file name to |
once this is ready for review and merge, we'll assign it the next CIP number. until ready for review, I think we can leave it as-is |
what's the rationale for removing plonk? |
@@ -0,0 +1,72 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- | |
| cip | TBD | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These suggestions will create a markdown table
@@ -0,0 +1,72 @@ | |||
--- | |||
title: Support ZK-SNARKS via GNARK in the Celestia Core cryptography |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Support ZK-SNARKS via GNARK in the Celestia Core cryptography | |
| - | - | | |
| title | Support ZK-SNARKS via GNARK in the Celestia Core cryptography | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review comments are adapting this file to fit the new format for the site at https://cips.celestia.org.
please also change the file name to cip-support-zk.md
or something similar for the time being, then once it is approved we will assign a number. thank you!
@@ -0,0 +1,72 @@ | |||
--- | |||
title: Support ZK-SNARKS via GNARK in the Celestia Core cryptography |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Support ZK-SNARKS via GNARK in the Celestia Core cryptography | |
| - | - | | |
| title | Support ZK-SNARKS via GNARK in the Celestia Core cryptography | |
@@ -0,0 +1,72 @@ | |||
--- | |||
title: Support ZK-SNARKS via GNARK in the Celestia Core cryptography | |||
description: Add the GNARK library to the Celestia Core codebase and make it available as an implementation tool for future CIPs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Add the GNARK library to the Celestia Core codebase and make it available as an implementation tool for future CIPs. | |
| description | Add the GNARK library to the Celestia Core codebase and make it available as an implementation tool for future CIPs. | |
--- | ||
title: Support ZK-SNARKS via GNARK in the Celestia Core cryptography | ||
description: Add the GNARK library to the Celestia Core codebase and make it available as an implementation tool for future CIPs. | ||
author: Sam Hart (@hxrts), Barry Plunkett (@bpiv400), Kristi Poldsam (@poldsam), Zaki Manian (@zmanian) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
author: Sam Hart (@hxrts), Barry Plunkett (@bpiv400), Kristi Poldsam (@poldsam), Zaki Manian (@zmanian) | |
| author | Sam Hart (@hxrts), Barry Plunkett (@bpiv400), Kristi Poldsam (@poldsam), Zaki Manian (@zmanian) | |
title: Support ZK-SNARKS via GNARK in the Celestia Core cryptography | ||
description: Add the GNARK library to the Celestia Core codebase and make it available as an implementation tool for future CIPs. | ||
author: Sam Hart (@hxrts), Barry Plunkett (@bpiv400), Kristi Poldsam (@poldsam), Zaki Manian (@zmanian) | ||
discussions-to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussions-to: | |
| discussions-to | https://forum.celestia.org/t/zero-knowledge-in-the-celestia-baselayer/1475 | |
Please change this if this isn't the best post to link, thanks!
description: Add the GNARK library to the Celestia Core codebase and make it available as an implementation tool for future CIPs. | ||
author: Sam Hart (@hxrts), Barry Plunkett (@bpiv400), Kristi Poldsam (@poldsam), Zaki Manian (@zmanian) | ||
discussions-to: | ||
status: Draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: Draft | |
| status | Draft | |
discussions-to: | ||
status: Draft | ||
type: Standards Track | ||
category: Core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
category: Core | |
| category | Core | |
status: Draft | ||
type: Standards Track | ||
category: Core | ||
created: 2024-02-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created: 2024-02-20 | |
| created | 2024-02-20 | |
type: Standards Track | ||
category: Core | ||
created: 2024-02-20 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- |
@@ -0,0 +1,72 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These suggestions will create a markdown table
|
||
## Copyright | ||
|
||
Copyright and related rights waived via [CC0](../LICENSE). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright and related rights waived via [CC0](../LICENSE). | |
Copyright and related rights waived via [CC0](https://github.com/celestiaorg/CIPs/blob/main/LICENSE). |
Overview
This is the first CIP from the ZK in the Celestia Baselayer Working group. It propose a concrete integration of the Gnark library into Celestia-core to support future CIPs.