Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cips): Clarify sampling window vs pruning window #75

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Feb 7, 2024

Sampling window (light nodes sampling blocks) = 30 days
Pruning window (full nodes storing and serving blocks) = 30 days + 1

Question:
Should we make clear definitions in the CIP to differentiate pruning window from sampling window?

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes. re:

Question:
Should we make clear definitions in the CIP to differentiate pruning window from sampling window?

I think adding definitions of "Sampling window" and "Pruning window" into the Specification would be beneficial.

cips/cip-4.md Outdated Show resolved Hide resolved
@jcstein
Copy link
Member

jcstein commented Feb 7, 2024

thanks @renaynay - what do you think about adding to the specs section?

Sampling window (light nodes sampling blocks) = 30 days
Pruning window (full nodes storing and serving blocks) = 30 days + 1

@renaynay
Copy link
Member Author

renaynay commented Feb 7, 2024

@jcstein pls take a look at 3d3cc5b

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcstein jcstein merged commit 6a589f4 into celestiaorg:main Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants