docs: move params to be gov unmodifiable #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
commented
Feb 6, 2024
Comment on lines
+150
to
+154
| Rough steps: | ||
|
|
||
| 1. Add two parameters to the [paramfilter](https://github.com/celestiaorg/celestia-app/tree/main/x/paramfilter) block list. | ||
| 1. Define two new versioned constants in the v2 directory for the two proposed parameter values. | ||
| 1. Explicitly set the two parameters to the versioned constants defined in step 2. |
There was a problem hiding this comment.
I plan on fleshing this out before moving this CIP from draft to review.
| ## Backwards Compatibility | ||
|
|
||
| This proposal is backwards compatible. However, clients that hard-coded gas estimation based on the previous `auth.TxSizeCostPerByte` value will need to be updated. | ||
|
|
||
| ## Test Cases | ||
|
|
||
| 1. Test this proposal on Mocha testnet | ||
| TBA |
There was a problem hiding this comment.
I plan on fleshing this out after working on the implementation.
jcstein
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @YazzyYaz