cip-19: add eds identifier/container #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
approved these changes
Mar 27, 2024
rootulp
approved these changes
Mar 27, 2024
walldiss
approved these changes
Mar 27, 2024
rootulp
approved these changes
Mar 27, 2024
Comment on lines
+154
to
+155
| Eds containers encapsulate the [DataSquare][square]. Internally, they only keep the original data(1st quadrant) of the | ||
| EDS with redundant data(2nd, 3rd and 4th quadrants) computable from the original data. |
There was a problem hiding this comment.
Suggested change
| Eds containers encapsulate the [DataSquare][square]. Internally, they only keep the original data(1st quadrant) of the | |
| EDS with redundant data(2nd, 3rd and 4th quadrants) computable from the original data. | |
| Eds containers encapsulate the [DataSquare][square]. Internally, they only keep the original data (1st quadrant) of the | |
| EDS with redundant data (2nd, 3rd and 4th quadrants) computable from the original data. |
Comment on lines
+186
to
+187
| Row containers encapsulate the rows of the [DataSquare][square]. Internally, they only keep the left(original) half of | ||
| the row with right(redundant) half recomputable from the left half. |
There was a problem hiding this comment.
Suggested change
| Row containers encapsulate the rows of the [DataSquare][square]. Internally, they only keep the left(original) half of | |
| the row with right(redundant) half recomputable from the left half. | |
| Row containers encapsulate the rows of the [DataSquare][square]. Internally, they only keep the left (original) half of | |
| the row with right (redundant) half recomputable from the left half. |
| | RowID | 0x7801 | 0x7800 | | ||
| | SampleID | 0x7811 | 0x7810 | | ||
| | DataID | 0x7821 | 0x7820 | | ||
|
|
||
| *EdsID and container are excluded from Bitswap composition. Bitswap is limited to messages of size 256kb, while EDSes are | ||
| expected to be bigger. Also, its more efficient to parallelize EDS requesting by rows. |
There was a problem hiding this comment.
Suggested change
| expected to be bigger. Also, its more efficient to parallelize EDS requesting by rows. | |
| expected to be bigger. Also, it is more efficient to parallelize EDS requesting by rows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the cip-19 with new identifier/container.