Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cip-19: Review status #109

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

Wondertan
Copy link
Member

Change status to review

@Wondertan
Copy link
Member Author

Or is it In Review? Also, where is the list of all the possible statuses?

@jcstein
Copy link
Member

jcstein commented Mar 20, 2024

@Wondertan
Copy link
Member Author

Found it, CIP-1

@jcstein
Copy link
Member

jcstein commented Mar 20, 2024

While CIP-1 doesn't mention anything about how long a CIP remains in Draft before going to Review, should this remain in Draft longer than just a few hours? cc @YazzyYaz @rootulp @ebuchman

@Wondertan
Copy link
Member Author

Actually, @jcstein, let's keep it as a draft; I will add one more container and ID type for the eds.

@rootulp
Copy link
Collaborator

rootulp commented Mar 20, 2024

While CIP-1 doesn't mention anything about how long a CIP remains in Draft before going to Review, should this remain in Draft longer than just a few hours? cc @YazzyYaz @rootulp @ebuchman

IMO there doesn't need to be a minimum time enforced on how long a CIP is in Draft before moving to Review.

Actually, @jcstein, let's keep it as a draft; I will add one more container and ID type for the eds.

Sounds good. Should this PR be closed?

@Wondertan
Copy link
Member Author

We may, but the transition to review will happen anyway, and it's also the case that the change will be strictly additive and won't change the existing doc, so it still makes sense to keep what exist in the review stage

Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused on the back and forth behind moving this to review but approving to unblock. Seems like not a big deal to make modifications to this doc even after it has been moved to review.

@Wondertan
Copy link
Member Author

@rootulp, we are new to the process and there are many little edge-cases like this one. I am thinking both directions to see the best one. I didn't mean to confuse you.

@jcstein jcstein merged commit fd94dd0 into celestiaorg:main Mar 20, 2024
5 checks passed
@Wondertan Wondertan deleted the cip-shwap_protocol_status branch March 22, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants