-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cip-19: Review status #109
Conversation
Or is it In Review? Also, where is the list of all the possible statuses? |
Review is correct, in CIP-1, https://github.com/celestiaorg/CIPs/blob/main/cips/cip-1.md#cip-process |
Found it, CIP-1 |
Actually, @jcstein, let's keep it as a draft; I will add one more container and ID type for the eds. |
IMO there doesn't need to be a minimum time enforced on how long a CIP is in Draft before moving to Review.
Sounds good. Should this PR be closed? |
We may, but the transition to review will happen anyway, and it's also the case that the change will be strictly additive and won't change the existing doc, so it still makes sense to keep what exist in the review stage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused on the back and forth behind moving this to review but approving to unblock. Seems like not a big deal to make modifications to this doc even after it has been moved to review.
@rootulp, we are new to the process and there are many little edge-cases like this one. I am thinking both directions to see the best one. I didn't mean to confuse you. |
Change status to review