Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: markdownlint #104

Merged
merged 3 commits into from
Mar 20, 2024
Merged

chore: markdownlint #104

merged 3 commits into from
Mar 20, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 19, 2024

Closes #93

@rootulp rootulp requested a review from jcstein March 19, 2024 17:09
@rootulp rootulp self-assigned this Mar 19, 2024
@rootulp rootulp marked this pull request as ready for review March 19, 2024 17:11
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one non-blocking comment

cips/cip-template.md Show resolved Hide resolved
@@ -14,13 +14,13 @@ requires: CIP number(s). Only required when you reference an CIP in the `Specifi
**READ CIP-1 BEFORE USING THIS TEMPLATE!**
This is the suggested template for new CIPs. After you have filled in the requisite fields, please delete these comments. Note that an CIP number will be assigned by an editor. When opening a pull request to submit your CIP, please use an abbreviated title in the filename, `cip-draft_title_abbrev.md`. The title should be 44 characters or less. It should not repeat the CIP number in title, irrespective of the category.

**TODO: Remove the note before submitting**
TODO: Remove the note before submitting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TODO: Remove the note before submitting
> **TODO: Remove the note before submitting**

maybe this could work? or, just remove bold

@rootulp rootulp merged commit b51a87c into celestiaorg:main Mar 20, 2024
8 checks passed
@rootulp rootulp deleted the rp/lint branch March 20, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Markdownlint CI action
3 participants