CIP-18: Standardised Gas and Pricing Estimation Interface #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
reviewed
Mar 13, 2024
cips/cip-tx-interface.md
Outdated
|
|
||
| The effectiveness of a "standardised" interface depends on the willingness of current and future clients to adopt it as well as the willingness of teams to provide those services. To set a sufficient precendent, both the Node API within `celestia-node` and the consensus node within `celestia-app` will implement client and server implementations respectively, creating an interface between the existing line of communication. That way by default, light nodes will use that API with the trusted provider they are already using for transaction submission. | ||
|
|
||
| The consensus node will use the SimulateTx method to estimate the gas used and use the `min_gas_price` parameter within state as the `estimated_gas_price` |
There was a problem hiding this comment.
I think SimulateTx is often used in conjunction with
--gas-adjustment float adjustment factor to be multiplied against the estimate returned by the tx simulation; if the gas limit is set manually this flag is ignored (default 1)
so should the initial implementation return the direct output of SimulateTx or multiplied by some factor (i.e. 1.1 or 1.2)?
There was a problem hiding this comment.
I don't have strong feelings on this. I would lean towards multiplying by 1.1
cips/cip-tx-interface.md
Outdated
| title: Standardised Gas and Pricing Estimation Interface | ||
| description: A standardised interface for estimating gas usage and gas pricing for transactions | ||
| author: Callum Waters (@cmwaters) | ||
| discussions-to: URL |
There was a problem hiding this comment.
Note: this needs a URL pre-merge.
There was a problem hiding this comment.
Yeah I haven't yet created the forum post but will do that today
cmwaters
commented
Mar 14, 2024
Co-authored-by: Rootul P <[email protected]>
rootulp
approved these changes
Mar 14, 2024
jcstein
changed the title
jcstein
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I have submitted this as part of the
Interfacecategory, but it may be better suited as a CRC. Let me know and I can easily change itChecklist