Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice for assets prop of library endpoint #113

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

MattIPv4
Copy link
Member

Type of Change

  • Routes/Pages: API

What issue does this relate to?

cc cdnjs/cdnjs#14140

What should this PR do?

Adds a deprecation notice to the library endpoint, indicating that the assets prop will no longer contain all versions. Updates the docs for the assets and versions props to reflect the same, and also updates the examples.

What are the acceptance criteria?

The library API endpoint is marked with a deprecation notice for the assets property.

@MattIPv4
Copy link
Member Author

Live in staging: https://cdnjs.dev/api#library

components/api/library.vue Outdated Show resolved Hide resolved
components/api/library.vue Outdated Show resolved Hide resolved
components/api/library.vue Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 merged commit e8b66c9 into master Jun 18, 2022
@MattIPv4 MattIPv4 deleted the MattIPv4/deprecate-all-assets branch June 18, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants