[New] Add [email protected] w/ git auto-update #12158

sashberd · 2017-11-12T07:42:35Z

Pull request for issue: #8979
Related issue(s): # #

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Git repository (required): https://github.com/wikimedia/jquery.ime
Official website (optional, not the repository): http://thottingal.in/projects/js/jquery.ime/examples/
NPM package url (optional):
License and its reference: GPL-2.0
GitHub / Bitbucket popularity (required):
- Count of watchers: 34
- Count of stars: 116
- Count of forks: 128
NPM download stats (optional):
- Downloads in the last day:
- Downloads in the last week:
- Downloads in the last month:

Essential checklist

I'm the author of this library
- I would like to add link to the page of this library on CDNJS on website / readme
This lib was not found on cdnjs repo
No already exist / duplicated issue and PR
The lib has notable popularity
- More than 200 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
- More than 800 downloads stats per month on npm registry
Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct.

Git commit checklist

The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
The parent of the commit(s) in the PR is not old than 3 days.
Pull request is sending from a non-master branch with meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

PeterBot

@sashberd congratulations! 2c75cc9 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/14988, thank you 😀

extend1994

Other than the following request, I think you should open a issue to check that is there stable version(s) they can release. The current latest one 1.0.0+20131229 seem not stable. The commit number of that one is 806 (See https://github.com/wikimedia/jquery.ime/tree/1.0.0+20131229). The commit number of master branch is 1065. There might be some versions they didn't tag/release yet.

extend1994 · 2017-11-20T15:43:31Z

ajax/libs/jquery.ime/package.json

+      {
+        "basePath": "",
+        "files": [
+          "!(README)",


Please remove this rule. It fetches so many files CDN doesn't need.

That was my mistake with pattern the !(README) should be included inside rules see here wikimedia/jquery.ime#453

extend1994 · 2017-11-20T15:46:24Z

ajax/libs/jquery.ime/package.json

+        "basePath": "",
+        "files": [
+          "!(README)",
+          "rules/**/*"


We also need

css/jquery.ime.css. Fetch it using the rule css/jquery.ime* (you can know this through .html file under example)

Because (1) is needed, all files under images should also be added too, use the rule images/*

sashberd · 2017-11-21T09:07:40Z

@santhoshtr @amire80 Following @extend1994 question about stable version release... Could you explain and help with this?
Thanks

sashberd · 2017-11-21T09:59:12Z

@extend1994 The PR was updated. FYR

PeterBot

@sashberd congratulations! 0fffefd CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/15311, thank you 😀

sufuf3

@sashberd Thanks for your contribution.

Would you discuss the git tag issue with the author?
https://github.com/wikimedia/jquery.ime/releases
The version name 1.0.0+20131229 is very weird.
Also, after this PR be merged, bot still add 1.0.0+20131229 version.
I think we have to exclude this 1.0.0+20131229 version via gitignore, but first of all, we have to get the good version name.
Should we need images/ime-inactive.svg & images/ime-inactive.png?
images/ime-active.svg & images/tick.svg is different from upstream (use md5sum chceck)

Many thanks.

sufuf3 · 2017-12-16T14:12:56Z

ajax/libs/jquery.ime/1.0.0/jquery.ime.css

@@ -0,0 +1,217 @@
+.imeselector {


The file structure should be

├── css │ └── jquery.ime.css

Many thanks.

I opened an issue. lets wait for the author answer

We need this files.. See the demo pages. It is used for show right bottom corner querty image

The files were updated from the stream with wget

sashberd · 2017-12-17T07:54:53Z

@sufuf3 The PR was updated. See comments above. FYR

PeterBot

@sashberd congratulations! 587a528 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/16257, thank you 😀

sashberd · 2018-02-09T22:24:03Z

@sufuf3 The authors added new normal version 0.2.0 see [here] (wikimedia/jquery.ime#505) The PR was updated. FYR

PeterBot

Oops 😨 db2cbba CI test failed ❗

@sashberd please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/17865 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@sashberd congratulations! 18cab92 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/17867, thank you 😀

sufuf3 · 2018-02-12T11:39:13Z

@sashberd As wikimedia/jquery.ime#505 (comment) comment, would you please update .gitignore file?
Many thanks.

PeterBot

@sashberd congratulations! 6dd67f8 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/17956, thank you 😀

sufuf3 · 2018-02-14T16:56:39Z

In the second commit message title Update .gitignore file, exclude v1.0.0+20131229, I don't know which lib need to be excluded v1.0.0+20131229.
Would you please mention the library name?
Many thanks.

Ref: https://github.com/cdnjs/cdnjs/search?q=gitignore&type=Commits&utf8=%E2%9C%93

sashberd · 2018-02-14T20:57:08Z

@sufuf The PR was updated. FYR

PeterBot

@sashberd congratulations! 8094d82 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/18027, thank you 😀

PeterBot · 2018-04-19T20:03:04Z

Any updates here? Please let me know if you need any help. Thanks!

(This is an automatic ping message, sorry for disturbing, we will get back here ASAP.)

cc @sashberd

sufuf3

The first commit message
Would you please fix the typo minifing?
The second commit message
Let's revise from
Update .gitignore file, exclude v1.0.0+20131229 of juery.ime lib to Update .gitignore to exclude [email protected]+20131229 to follow 50/72 rule closer.

Many thanks.

sashberd · 2018-04-26T11:46:32Z

@sufuf3 The commit messages were revised. FYR

PeterBot

Oops 😨 91f22fb CI test failed ❗

@sashberd please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/20043 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@sashberd congratulations! 34ff55b CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/20045, thank you 😀

sufuf3

@sashberd Thanks for the PR.
Some files are different from upstream.

In this PR

7ab007ba9302957722e03444d8063da2  ajax/libs/jquery.ime/0.2.0/rules/mn/mn-todo.js
a939bc31d22b5c33aee6b8d62df982df  ajax/libs/jquery.ime/0.2.0/rules/mn/mn-tradali.js
fac8a594afbfa52913031c77bc324985  ajax/libs/jquery.ime/0.2.0/rules/mn/mn-trad.js
a939bc31d22b5c33aee6b8d62df982df  ajax/libs/jquery.ime/0.2.0/rules/mn/mn-tradali.js
e9df25e99535c8d8cb33bcbb9fe812f0  ajax/libs/jquery.ime/0.2.0/rules/mn/phagspa.js
6f0946d2ca6d9e188f352796a2fdd39d  ajax/libs/jquery.ime/0.2.0/rules/mnc/mnc.js
b952fada91541cb6b8f7248e2d2e12f5  ajax/libs/jquery.ime/0.2.0/rules/mnc/mnc-ali.js
a82f0bafd7f3bdfe4ccabc6c55d326b8  ajax/libs/jquery.ime/0.2.0/rules/sjo/sjo.js

Upstream

72fb8d9b79b76fb007d3e8aebc392e77  ajax/libs/jquery.ime/0.2.0/rules/mn/mn-todo.js
8c675e67d2e5b410048d9c26c0a65dcc  ajax/libs/jquery.ime/0.2.0/rules/mn/mn-todoali.js
671cabda7f5f87b20ceff18007ceaf1b  ajax/libs/jquery.ime/0.2.0/rules/mn/mn-trad.js
a6c3c3e6619f6c5a22871085de5e6127  ajax/libs/jquery.ime/0.2.0/rules/mn/mn-tradali.js
bbcc01e272af6fb9291b1de031ac84a3  ajax/libs/jquery.ime/0.2.0/rules/mn/phagspa.js
d384b6758040a37016a903f1bd5b1684  ajax/libs/jquery.ime/0.2.0/rules/mnc/mnc-ali.js
27d099da007701b945d9c16c7ec919a8  ajax/libs/jquery.ime/0.2.0/rules/mnc/mnc.js
cb20b74e57c93a0104f3d6d44d2e1b26  ajax/libs/jquery.ime/0.2.0/rules/sjo/sjo.js

Would you please re-add them and re-generate the minified files.
Thank you.

sufuf3 · 2018-04-27T03:04:58Z

ajax/libs/jquery.ime/package.json

+    "localization",
+    "ime",
+    "jquery",
+    "l10n"


Let's add more keywords(like intl) to help people to search this lib.

Thanks

sufuf3 · 2018-04-27T03:06:47Z

ajax/libs/jquery.ime/package.json

+    "type": "git",
+    "url": "git://github.com/wikimedia/jquery.ime.git"
+  },
+  "filename": "jquery.ime.min.js",


Let's move this line in second order.
To help people see it at the first glance.
Thank you.

sashberd · 2018-04-29T09:12:07Z

@sufuf3 The PR was updated. FYR

PeterBot

@sashberd congratulations! 9878e18 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/20127, thank you 😀

sufuf3

LGTM
Thanks for the contribution.

PS.
I got the files using the auto-updater and generated the minified files. However, I found some files are different from my result. These files are as the following:

        modified:   ajax/libs/jquery.ime/0.2.0/jquery.ime.min.js
        modified:   ajax/libs/jquery.ime/0.2.0/jquery.ime.min.js.map
        modified:   ajax/libs/jquery.ime/0.2.0/jquery.ime.selector.min.js
        modified:   ajax/libs/jquery.ime/0.2.0/jquery.ime.selector.min.js.map
        modified:   ajax/libs/jquery.ime/0.2.0/rules/bo/bo-sambhota.min.js

Not sure the cause is from the version of minified tool.

I have forgotten to reminder cc #8979 in the second commit, but I think maybe it fine here.

close cdnjs#8979, cc @wikimedia, using web-minify-helper for minifying files

The version was excluded according to wikimedia/jquery.ime#505 (comment)

PeterBot

@sashberd congratulations! e452665 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/20417, thank you 😀

ghost assigned sashberd Nov 12, 2017

ghost added the in progress label Nov 12, 2017

PeterBot approved these changes Nov 12, 2017

View reviewed changes

sufuf3 requested review from dakshshah96, sufuf3, maruilian11 and extend1994 November 13, 2017 15:13

extend1994 suggested changes Nov 20, 2017

View reviewed changes

sashberd requested a review from extend1994 November 21, 2017 09:58

sashberd force-pushed the jquery.ime branch from 2c75cc9 to 0fffefd Compare November 21, 2017 09:59

PeterBot approved these changes Nov 21, 2017

View reviewed changes

sufuf3 suggested changes Dec 16, 2017

View reviewed changes

sashberd mentioned this pull request Dec 17, 2017

cdnjs hosting wikimedia/jquery.ime#505

Open

sashberd requested a review from sufuf3 December 17, 2017 07:53

sashberd force-pushed the jquery.ime branch from 0fffefd to 587a528 Compare December 17, 2017 07:54

PeterBot approved these changes Dec 17, 2017

View reviewed changes

sashberd changed the title ~~Add [email protected] w/ git auto-update~~ Add [email protected] w/ git auto-update Feb 9, 2018

sashberd force-pushed the jquery.ime branch from 587a528 to db2cbba Compare February 9, 2018 22:24

sashberd removed the request for review from maruilian11 February 9, 2018 22:24

PeterBot suggested changes Feb 9, 2018

View reviewed changes

sashberd force-pushed the jquery.ime branch from db2cbba to 18cab92 Compare February 9, 2018 22:31

PeterBot approved these changes Feb 9, 2018

View reviewed changes

sashberd force-pushed the jquery.ime branch from 18cab92 to 6dd67f8 Compare February 12, 2018 19:52

PeterBot approved these changes Feb 12, 2018

View reviewed changes

sashberd force-pushed the jquery.ime branch from 6dd67f8 to 8094d82 Compare February 14, 2018 20:59

PeterBot approved these changes Feb 14, 2018

View reviewed changes

sufuf3 suggested changes Apr 25, 2018

View reviewed changes

sufuf3 changed the title ~~Add [email protected] w/ git auto-update~~ [New] Add [email protected] w/ git auto-update Apr 25, 2018

sashberd force-pushed the jquery.ime branch from 8094d82 to 91f22fb Compare April 26, 2018 11:46

sashberd requested a review from sufuf3 April 26, 2018 11:46

PeterBot suggested changes Apr 26, 2018

View reviewed changes

sashberd force-pushed the jquery.ime branch from 91f22fb to 34ff55b Compare April 26, 2018 12:29

PeterBot approved these changes Apr 26, 2018

View reviewed changes

sufuf3 suggested changes Apr 27, 2018

View reviewed changes

sashberd requested a review from sufuf3 April 29, 2018 09:12

sashberd force-pushed the jquery.ime branch from 34ff55b to 9878e18 Compare April 29, 2018 09:13

PeterBot approved these changes Apr 29, 2018

View reviewed changes

sufuf3 approved these changes May 3, 2018

View reviewed changes

sufuf3 requested a review from PeterDaveHello May 3, 2018 03:19

sashberd added 2 commits May 11, 2018 17:35

Add [email protected] w/ git auto-update

730f6f3

close cdnjs#8979, cc @wikimedia, using web-minify-helper for minifying files

Update .gitignore to exclude [email protected]+20131229

e452665

The version was excluded according to wikimedia/jquery.ime#505 (comment)

PeterDaveHello force-pushed the jquery.ime branch from 9878e18 to e452665 Compare May 11, 2018 09:36

ghost assigned PeterDaveHello May 11, 2018

PeterBot approved these changes May 11, 2018

View reviewed changes

PeterDaveHello approved these changes May 11, 2018

View reviewed changes

PeterDaveHello merged commit 2d8f800 into cdnjs:master May 11, 2018

ghost removed the in progress label May 11, 2018

sashberd deleted the jquery.ime branch May 13, 2018 08:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New] Add [email protected] w/ git auto-update #12158

[New] Add [email protected] w/ git auto-update #12158

sashberd commented Nov 12, 2017

PeterBot left a comment

extend1994 left a comment

extend1994 Nov 20, 2017

sashberd Nov 21, 2017

extend1994 Nov 20, 2017

sashberd commented Nov 21, 2017 •

edited

Loading

sashberd commented Nov 21, 2017

PeterBot left a comment

sufuf3 left a comment

sufuf3 Dec 16, 2017

sashberd Dec 17, 2017

sashberd commented Dec 17, 2017

PeterBot left a comment

sashberd commented Feb 9, 2018

PeterBot left a comment

PeterBot left a comment

sufuf3 commented Feb 12, 2018

PeterBot left a comment

sufuf3 commented Feb 14, 2018 •

edited

Loading

sashberd commented Feb 14, 2018

PeterBot left a comment

PeterBot commented Apr 19, 2018

sufuf3 left a comment

sashberd commented Apr 26, 2018

PeterBot left a comment

PeterBot left a comment

sufuf3 left a comment

sufuf3 Apr 27, 2018

sufuf3 Apr 27, 2018

sashberd commented Apr 29, 2018

PeterBot left a comment

sufuf3 left a comment

PeterBot left a comment

[New] Add [email protected] w/ git auto-update #12158

[New] Add [email protected] w/ git auto-update #12158

Conversation

sashberd commented Nov 12, 2017

Profile of the lib

Essential checklist

Auto-update checklist

Git commit checklist

PeterBot left a comment

Choose a reason for hiding this comment

extend1994 left a comment

Choose a reason for hiding this comment

extend1994 Nov 20, 2017

Choose a reason for hiding this comment

sashberd Nov 21, 2017

Choose a reason for hiding this comment

extend1994 Nov 20, 2017

Choose a reason for hiding this comment

sashberd commented Nov 21, 2017 • edited Loading

sashberd commented Nov 21, 2017

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

sufuf3 Dec 16, 2017

Choose a reason for hiding this comment

sashberd Dec 17, 2017

Choose a reason for hiding this comment

sashberd commented Dec 17, 2017

PeterBot left a comment

Choose a reason for hiding this comment

sashberd commented Feb 9, 2018

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 commented Feb 12, 2018

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 commented Feb 14, 2018 • edited Loading

sashberd commented Feb 14, 2018

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot commented Apr 19, 2018

sufuf3 left a comment

Choose a reason for hiding this comment

sashberd commented Apr 26, 2018

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

sufuf3 Apr 27, 2018

Choose a reason for hiding this comment

sufuf3 Apr 27, 2018

Choose a reason for hiding this comment

sashberd commented Apr 29, 2018

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sashberd commented Nov 21, 2017 •

edited

Loading

sufuf3 commented Feb 14, 2018 •

edited

Loading