Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arc-runner => github-actions in CI #494

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

segeljakt
Copy link
Member

No description provided.

@@ -5,7 +5,7 @@ set -e # Terminates as soon as something fails
echo "The work dir is ${ARC_MLIR_BUILD}"

export PATH="$ARC_MLIR_BUILD/llvm-build/bin:$PATH"
export RUSTC_WRAPPER="/home/arc-runner/.cargo/bin/sccache"
export RUSTC_WRAPPER="/home/github-actions/.cargo/bin/sccache"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure /home/github-actions is persisted between invocations of the runner?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ok, this is running in a docker image on my personal computer.

Copy link
Member Author

@segeljakt segeljakt Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only thing that might change is the

/home/github-actions/actions-runner/Workspace/

directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@segeljakt segeljakt force-pushed the klas/update-ci-home-directory branch 2 times, most recently from d83fb5c to d58f258 Compare August 14, 2023 14:10
@segeljakt segeljakt requested a review from frej August 14, 2023 14:30
Copy link
Contributor

@frej frej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't just disable the arc-runtime, it breaks all test cases which produce and compile Rust. I don't care about arc-lang-to-rust/* but arc-to-rust/* and rust/* are important to ensure that pulling in stuff from upstream doesn't break stuff.

@segeljakt
Copy link
Member Author

Hmm ok, all the checks went through CI so I got confused.

The runtime has problems upstream because of the Rust nightly version being used. It might be possible to by rolling back to an earlier nightly version. I will try to see if that's the case. Which nightly version are you using right now?

@frej
Copy link
Contributor

frej commented Aug 15, 2023

Hmm ok, all the checks went through CI so I got confused.

I see one failure. "test / build (pull_request) Failing after 1m"

Which nightly version are you using right now?

I'm on 1.71.1, although I haven zapped ~/.cargo lately, so maybe I'm saved by having old cached stuff.

@segeljakt
Copy link
Member Author

Oh, I got very confused. I was checking the actions https://github.com/cda-group/arc/actions page and thought the first run represented all the checks 😅

@segeljakt segeljakt force-pushed the klas/update-ci-home-directory branch from d58f258 to 25ca8be Compare August 15, 2023 07:59
@segeljakt
Copy link
Member Author

I was able to roll back to version 1.70.0 and things seem to work

@segeljakt
Copy link
Member Author

The klas/v1 branch, and future updates, will only rely on the stable branch to avoid these issues

@segeljakt segeljakt merged commit fec017c into master Aug 15, 2023
3 checks passed
@segeljakt segeljakt deleted the klas/update-ci-home-directory branch August 15, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants