Replace (unmaintained) orderedset with ordered_set #1020
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The |
Contributor
|
Maybe libtbx/containers.py can cover the functionality, and there won't be a need for just another dependency? Or should we consider removing cctbx implementation for the sake of consistency? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it seems that the orderedset module is abandoned by its author, and it started failing; in particular with Python 3.13 as discovered in Debian, but see also simonpercivall/orderedset#36
There's an API-compatible replacement called ordered_set, see https://github.com/rspeer/ordered-set
This patch replaces the one with the other. It's already been used as part of the Debian packaging of cctbx with no influence on the build or the testsuite. I suggest applying it to upstream cctbx.