Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: remove grpc-health-probe check for false alarm #54

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

dongx1x
Copy link
Member

@dongx1x dongx1x commented Apr 22, 2024

  • grpc-health-probe sometimes gets timeout when heavy traffic, the service will be killed with exit code 137, remove this check.
  • revert the test in the example code.

grpc-health-probe sometimes gets timeout when heavy traffic, the
service will be killed with exit code 137, remove this check.

Signed-off-by: Xiaocheng Dong <[email protected]>
@dongx1x dongx1x requested review from Ruoyu-y and ruomengh April 22, 2024 02:38
Copy link
Contributor

@ruomengh ruomengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruomengh
Copy link
Contributor

Seems this is a known issue in grpc-health-probe project: grpc-ecosystem/grpc-health-probe#33

@dongx1x dongx1x merged commit 07e14c8 into cc-api:main Apr 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants