Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automated dark / follow system settings mode #1806

Open
wants to merge 6 commits into
base: v2-develop
Choose a base branch
from

Conversation

jessehickman
Copy link
Contributor

Will switch between light/dark style automatically based on window.matchMedia. Config setting is false by default.

Adding setScheme();
Added autoDarkMode default config
Updated style settingsOption. Added autoDarkMode settings option. Added public function setScheme.
Updated function launch with darkmode settings
Adding darkmode to /launch
Updating settingsOption and public function setScheme to be more dynamic
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@causefx
Copy link
Owner

causefx commented Mar 25, 2022

Let me think about this, we could use the activeInfo var instead of setting more cookies.

@jessehickman
Copy link
Contributor Author

Let me think about this, we could use the activeInfo var instead of setting more cookies.

Definitely. I reworked code that I used elsewhere but it definitely doesn't have to be cookies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants