Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shell is also a supported executor #1037

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: shell is also a supported executor #1037

wants to merge 1 commit into from

Conversation

lmilbaum
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

Migrations required

YES | NO - If yes please describe the migration.

Verification

Please mention the examples you have verified.

@github-actions GitHub Actions
Copy link
Contributor

Hey @lmilbaum! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@lmilbaum lmilbaum changed the title shell is also a supported executor feat: shell is also a supported executor Nov 11, 2023
@lmilbaum lmilbaum force-pushed the variable branch 7 times, most recently from d85ffec to d20ed4d Compare November 11, 2023 20:02
@kayman-mk
Copy link
Collaborator

I know it's not ready for review. But I saw the changes in the variables.tf which are not backwards compatible. We can only do that with the v8 release end of 2024.

@lmilbaum
Copy link
Contributor Author

I know it's not ready for review. But I saw the changes in the variables.tf which are not backwards compatible. We can only do that with the v8 release end of 2024.

IC. Thank you for your feedback. I'll do some changes.

@lmilbaum lmilbaum force-pushed the variable branch 9 times, most recently from 053c294 to 1373250 Compare November 12, 2023 17:19
@kayman-mk
Copy link
Collaborator

@lmilbaum Are you still working on this feature?

@lmilbaum
Copy link
Contributor Author

lmilbaum commented Dec 1, 2023

@lmilbaum Are you still working on this feature?

Sorry. Don't have the cycles for it in the coming weeks. If you or any one else wants to chime in.

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Jan 31, 2024
@kayman-mk kayman-mk added work-in-progress Issue/PR is worked, should not become stale and removed stale Issue/PR is stale and closed automatically labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm Awaiting requested review from npalm npalm will be requested when the pull request is marked ready for review npalm is a code owner

@kayman-mk kayman-mk Awaiting requested review from kayman-mk kayman-mk will be requested when the pull request is marked ready for review kayman-mk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
work-in-progress Issue/PR is worked, should not become stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmilbaum @kayman-mk