Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Tagging network-interface in tag_specifications Block #1207

Closed
mandresuri opened this issue Nov 21, 2024 · 0 comments · Fixed by #1212 or #1211
Closed

Add Support for Tagging network-interface in tag_specifications Block #1207

mandresuri opened this issue Nov 21, 2024 · 0 comments · Fixed by #1212 or #1211

Comments

@mandresuri
Copy link

Describe the solution you'd like

I would like the ability to add tags for the network-interface resource in the tag_specifications block of our Terraform configuration. This would allow consistent tagging across all resources associated with an instance, such as volumes, spot instance requests, and network interfaces.

The use case for this feature is to ensure all resources are easily identifiable and aligned with the tagging policies defined in local.tags. This can be particularly useful for auditing, resource tracking, and cost management.

Describe alternatives you've considered

Manual tagging: I have considered adding the tags manually to the network-interface after resource creation. However, this approach is error-prone, does not scale, and introduces inconsistencies in infrastructure as code.

Custom modules: Another alternative was to write custom modules to handle tagging for all associated resources, but this adds unnecessary complexity and duplicates functionality already provided in the tag_specifications block.

Suggest a solution

Add a new tag_specifications block for the network-interface resource type:

tag_specifications {
  resource_type = "network-interface"
  tags          = local.tags
}

Additional context

This proposal aims to align with tagging policies for EC2-related resources. The feature would be consistent with existing blocks for volume and spot-instances-request.

Adding the network-interface tag support would provide a unified approach to resource tagging and ensure compliance with tagging requirements.

kayman-mk pushed a commit that referenced this issue Nov 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.0.1](8.0.0...8.0.1)
(2024-11-29)


### Bug Fixes

* add additional tags to the worker role
([#1210](#1210))
([0fe1617](0fe1617))
* add missing `tag_specifications` for launch templates
([#1212](#1212))
([28f06af](28f06af)),
closes
[#1207](#1207)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant