fix: add missing tag_specifications for launch templates (#1212)

## Description Some of the `tag_specifications` were missing and are added in this PR. Leads to more resources being tagged correctly. Closes #1207
cattle-ops · Nov 29, 2024 · 28f06af · 28f06af
1 parent 0fe1617
commit 28f06af
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/docker_autoscaler.tf b/docker_autoscaler.tf
@@ -97,11 +97,14 @@ resource "aws_launch_template" "this" {
     resource_type = "instance"
     tags          = local.tags
   }
-
   tag_specifications {
     resource_type = "volume"
     tags          = local.tags
   }
+  tag_specifications {
+    resource_type = "network-interface"
+    tags          = local.tags
+  }
 
   tags = local.tags
 

diff --git a/main.tf b/main.tf
@@ -308,6 +308,10 @@ resource "aws_launch_template" "gitlab_runner_instance" {
     resource_type = "volume"
     tags          = local.tags
   }
+  tag_specifications {
+    resource_type = "network-interface"
+    tags          = local.tags
+  }
   dynamic "tag_specifications" {
     for_each = var.runner_instance.spot_price == null || var.runner_instance.spot_price == "" ? [] : ["spot"]
     content {
@@ -410,6 +414,11 @@ resource "aws_launch_template" "fleet_gitlab_runner" {
     resource_type = "volume"
     tags          = local.tags
   }
+  tag_specifications {
+    resource_type = "network-interface"
+    tags          = local.tags
+  }
+  # tag_specifications for spot-instances-request do not work. Instance creation fails.
 
   tags = local.tags