Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1143 #1180

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Fix #1143 #1180

wants to merge 10 commits into from

Conversation

h-mayorquin
Copy link
Collaborator

This change addresses issues like bug #1114.

The core problem lies in the risk of creating a new interface without adhering to the implicit contract for importing extensions during initialization. This PR eliminates the possibility of unintentionally introducing subtle, hard-to-detect bugs. Furthermore, as highlighted in #1143, the logic without a context manager is simpler to understand and covers approximately 95% of use cases.

@h-mayorquin h-mayorquin self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.08%. Comparing base (96dfdff) to head (980ca72).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
src/neuroconv/basedatainterface.py 41.66% 7 Missing ⚠️
src/neuroconv/nwbconverter.py 36.36% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
- Coverage   90.69%   90.08%   -0.61%     
==========================================
  Files         129      129              
  Lines        8189     8311     +122     
==========================================
+ Hits         7427     7487      +60     
- Misses        762      824      +62     
Flag Coverage Δ
unittests 90.08% <39.13%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/neuroconv/tools/testing/data_interface_mixins.py 95.65% <ø> (+0.09%) ⬆️
src/neuroconv/basedatainterface.py 80.00% <41.66%> (-15.35%) ⬇️
src/neuroconv/nwbconverter.py 83.21% <36.36%> (-11.75%) ⬇️

... and 17 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant