Install RAG24 baseline + update docs #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2638 +/- ##
=========================================
Coverage 65.59% 65.59%
Complexity 1480 1480
=========================================
Files 225 225
Lines 13010 13010
Branches 1551 1551
=========================================
Hits 8534 8534
Misses 3949 3949
Partials 527 527 ☔ View full report in Codecov by Sentry. |
ronakice
requested changes
Dec 9, 2024
README.md
Outdated
| @@ -291,12 +291,28 @@ Key: | |||
|
|
|||
| </details> | |||
| <details> | |||
| <summary>MS MARCO V2.1 Document Regressions</summary> | |||
| <summary>MS MARCO V2.1 Passage Regressions (TREC RAG 24)</summary> | |||
There was a problem hiding this comment.
Terminology here can be misleading, if we are doing segmented maybe we should say that instead of passage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that rag2024 regression doesn't actually work yet, we're blocked on #2639
However, since @UShivani3 is currently away, I'd like to get his merged first and then circle back to fix.