Suppress NuGet licenseUrl deprecation warning
#481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing what the warning says and replacing `licenseUrl` with `license` will result in a broken NuGet package as not all tools are ready yet for the new `license` element. Let's wait a little and suppress this warning in the meantime. References: * NuGet/Home#7509 * NuGet/Home#7547
jonorossi
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can no longer get Windsor to build due to that pesky NuGet "The
licenseUrlelement will be deprecated" warning combined with Windsor's use of<TreatWarningsAsErrors>.This adds a suppression for that warning as per castleproject/NVelocity#14 (comment).
(Regarding the duplication in this PR, I refrained from putting the suppression in a
common.propslike Core has got, or even in a default MSBuildDirectory.Build.props. Reorganizing the build is probably best left to another dedicated PR.)