Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet: <licenseUrl> element will be deprecated #14

Open
jonorossi opened this issue Dec 17, 2018 · 2 comments
Open

NuGet: <licenseUrl> element will be deprecated #14

jonorossi opened this issue Dec 17, 2018 · 2 comments

Comments

@jonorossi
Copy link
Member

NuGet outputs the following warning during packaging. We should change to specify the license.

WARNING: <licenseUrl> element will be deprecated,please consider switching to specifying the license in the package. Learn more: https://aka.ms/deprecateLicenseUrl.

While here it would be good to reinstate the Castle logo on the package, I know the icon can now be embedded into the package which is definitely much better than pointing to the web site.

@stakx
Copy link
Member

stakx commented Mar 25, 2019

According to NuGet/Home#7509 (comment) and NuGet/Home#7547 tools aren't actually ready for <license> yet, and switching now could result in a corrupted NuGet package. We should perhaps track those issues and wait a little longer.

@jonorossi
Copy link
Member Author

@stakx the warning has been there for quite a while and the registry doesn't support it yet, wow.

We should probably just suppress NU5125 like everyone else (including the ASP.NET team) is doing and move on for now, sounds like it'll be a year or two before we can do much while the new tools get out there when it happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants