Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1202 index file cleanup #1217

Merged
merged 10 commits into from
Jul 19, 2023
Merged

1202 index file cleanup #1217

merged 10 commits into from
Jul 19, 2023

Conversation

ipopescu
Copy link
Collaborator

@ipopescu ipopescu commented Jul 17, 2023

What does this PR fix/introduce?

Open question for @ACStoneCL: sometimes articles are missing in a sidebar, to keep titles shorter, but I kept them in this PR. Examples: Archive and Restore a DB vs. Archive and Restore DB, Move a Node vs. Move Node, Join a Network vs. Join Network. What do you think?

Screenshot 2023-07-17 at 19 48 28

I've discovered issue #1216 while working on this PR.

Closes #1202

Checklist

  • Docs are successfully building - yarn install && yarn run build.
  • For new internal links I used relative file paths (with .md extension) - e.g. ../../faq/faq-general.md - instead of introducing absolute file path, or relative/absolute URL.
  • All external links have been verified with yarn run check:externals.
  • My changes follow the Casper docs style guidelines.

Reviewers

@ACStoneCL @andrzej-casper

FYI @Adrian-Wrona

@ipopescu ipopescu requested review from ACStone-MTS and a user July 17, 2023 17:51
Copy link
Contributor

@ACStone-MTS ACStone-MTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM - as far as the titles in the sidebar, I don't have a strong opinion beyond making sure that they are easily readable.

@ipopescu
Copy link
Collaborator Author

Thanks @ACStoneCL!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's much easier to navigate sidebar and breadcrumbs are working 😁


I found one place where collapsible category is not merged with index (thus breadcrumb is broken):

image

I suggest moving subpage Introduction directly to Why Build on Casper, and moving out Ecosystem Open-Source Software.

@ghost
Copy link

ghost commented Jul 18, 2023

Top level sections can be shown with #1219.

@ipopescu
Copy link
Collaborator Author

ipopescu commented Jul 19, 2023

@andrzej-casper I am addressing your request in this branch: 1200_navigation_resources. I started doing the change you requested right after our call, but the PR got too big. Please approve this one, and then I will raise another PR for the 1200_navigation_resources branch. I am trying to break down the work in manageable PRs, but there is still some inter-connectedness.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ipopescu Let's merge it then!

@ipopescu ipopescu merged commit 82349ad into dev Jul 19, 2023
12 checks passed
@ipopescu ipopescu deleted the 1202_index_cleanup branch July 19, 2023 15:31
ghost pushed a commit that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup index files from collapsible categories
2 participants