Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Algolia configurable via GitHub vars (not secrets) #1184

Merged
1 commit merged into from
Jul 6, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2023

What does this PR fix?

Currently Algolia config is stored in repository secrets, although it is not secret at all:

image

That is why we should use variables instead - it will make configuration inspection easier.

Checklist

@ghost ghost requested a review from bradjohnl July 6, 2023 12:02
@ghost ghost requested a review from ACStone-MTS as a code owner July 6, 2023 12:02
@ghost
Copy link
Author

ghost commented Jul 6, 2023

I created new variables, according to the current Algolia configuration:

image

The bottom ones (with _SITE_) are the configuration for the navbar search.

TODO: Remove relevant secrets, once this PR gets merged.

@bradjohnl
Copy link
Contributor

As discussed, approving this PR. We will test using the correct index for navbar and docs separately as it's something that requires playing with vars only

@ghost ghost merged commit a32e6f7 into dev Jul 6, 2023
6 checks passed
@ghost ghost deleted the fix/algolia-setup-is-not-secret branch July 6, 2023 12:37
@ghost
Copy link
Author

ghost commented Jul 7, 2023

  1. Backported to docs-new in casper-network/docs-new@7d58a74.
  2. Unnecessary secrets removed from docs and docs-new.

@ghost
Copy link
Author

ghost commented Jul 7, 2023

For the record, docs variables are updated to the new values provided by @bradjohnl:

image

docs-new as well:

image

On both environments navbar search works as expected, e.g.

image

@ghost ghost mentioned this pull request Jul 7, 2023
2 tasks
ghost pushed a commit that referenced this pull request Aug 21, 2023
…-secret

Make Algolia configurable via GitHub vars (not secrets)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant