Bradjohnl ci fix perm after k8s upgrade quick #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjohnl
force-pushed
the
bradjohnl_ci_fix-perm-after-k8s-upgrade-quick
branch
from
8fdfac7
to
8c09a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than trying to fix many things at once, I am doing this workaround first to make sure that we can go to Prod as the container will likely work on K8S without encountering the permission issue trying to spin up a privileged port.
This PR also fixes the issue of the container staying up when NGINX fails (php-fpm being the main process instead of NGINX).
If time permits, I will address the other issues, which are non-blocking, with other PRs: