Complete feature std-fs-io in casper-client feat-2.0 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.toml # lib/cli.rs # lib/cli/deploy.rs
…tem/casper-client-rs into rustSDK # Conflicts: # Cargo.toml # lib/cli.rs # lib/cli/parse.rs
|
@jacek-casper I believe there is no CI/CD running on feat-track-2.0 branch and that we sould probably add it in for this branch for PR because it seems to me the branch might not pass cargo audit and clippy |
|
You're right @gRoussac , the CI is not enabled here, it might be worth adding the branch to the workflow file: |
jacek-casper
approved these changes
Jul 12, 2024
|
@jacek-casper You review was great thanks again, I need the PR on node to be merged first and then I will imply Rafal for this one two before merging. |
rafal-ch
approved these changes
Jul 18, 2024
…per-client-rs into rustSDK-feat-2.0 # Conflicts: # lib/rpcs/v1_5_0/speculative_exec.rs
…per-client-rs into rustSDK-feat-2.0
…per-client-rs into rustSDK-feat-2.0 # Conflicts: # .github/workflows/ci-casper-client-rs.yml # Cargo.toml
…per-client-rs into rustSDK-feat-2.0 # Conflicts: # Cargo.toml # lib/cli/tests.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wasm32-unknown-unknown target
Add default fetaure
Add
std-fs-ioRemove filesystem I/O functionality from the
stdfeature, and gate this behind a new featurestd-fs-iowhich depends upon std.Allows to compile types without
secret_key_from_file/read_transaction_file/make_transaction/send_transaction_file/speculative_send_transaction_file/sign_transaction_file/json_pretty_print/....Update crates
Add
with_bytes()/session_bytestoSessionStrParamspayment_bytestoPaymentStrParams`Pub
struct JsonArgMutualize code for
get_maybe_secret_key()Add
lint-no-default-features/check-no-default-features/keygen::runAdd documentation on
args_from_simple_or_jsonAdd some Clone on exposed result types
Change tokio to
[tokio::main(flavor = "current_thread")]as dev branch (required)