Add setContent variant which returns initial snapshot
#2548
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squarejesse
reviewed
Jan 29, 2025
| } | ||
|
|
||
| // Defer to allow effect to run. | ||
| delay(10.milliseconds) |
There was a problem hiding this comment.
Would yield() be sufficient?
There was a problem hiding this comment.
I guess your goal is to guarantee any amount of yielding would still not get that value
There was a problem hiding this comment.
Yes. This is a stand in for arbitrary code that absolutely causes a dispatch. Yield is probably enough, but might not be. Could also be a runCurrent() which is basically what delay becomes in runTest.
squarejesse
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.