Update re-attached widget removes to use detach #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw.movable-content.2024-11-15
branch
from
85b814f to
1920eef
Compare
This ensures that the host-side maintains their instances to correctly support re-attach.
JakeWharton
force-pushed
the
jw.movable-content.2024-11-15
branch
from
1920eef to
3b50c8b
Compare
squarejesse
reviewed
Dec 16, 2024
...l-guest/src/commonMain/kotlin/app/cash/redwood/protocol/guest/DefaultGuestProtocolAdapter.kt
Outdated
Show resolved
Hide resolved
squarejesse
reviewed
Dec 16, 2024
| } | ||
| } | ||
|
|
||
| assertThat(composition.awaitSnapshot().filter { it !is ValueChange }).containsExactly( |
squarejesse
reviewed
Dec 16, 2024
| ) | ||
|
|
||
| state = 1 | ||
| assertThat(composition.awaitSnapshot().filter { it !is ValueChange }).containsExactly( |
There was a problem hiding this comment.
The ValueChange instances all target the new Column here, right?
squarejesse
reviewed
Dec 16, 2024
| state = 1 | ||
| assertThat(composition.awaitSnapshot().filter { it !is ValueChange }).containsExactly( | ||
| // Box from Row | ||
| ChildrenChange.Remove(Id(1), ChildrenTag(1), 0, detach = true), |
squarejesse
reviewed
Dec 16, 2024
| ) | ||
| } | ||
|
|
||
| @Test fun multipleMovableContentButOnlyOneReused() = runTest { |
squarejesse
approved these changes
Dec 16, 2024
|
You made it look easy |
JakeWharton
commented
Dec 16, 2024
...-tooling-codegen/src/main/kotlin/app/cash/redwood/tooling/codegen/protocolGuestGeneration.kt
Outdated
Show resolved
Hide resolved
…ng/codegen/protocolGuestGeneration.kt
JakeWharton
commented
Dec 16, 2024
...l-guest/src/commonMain/kotlin/app/cash/redwood/protocol/guest/DefaultGuestProtocolAdapter.kt
Outdated
Show resolved
Hide resolved
…protocol/guest/DefaultGuestProtocolAdapter.kt
Extracting like 8 infrastructure PRs out from before it certainly helped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the host-side maintains their instances to correctly support re-attach.
Closes #1902
movable.webm
CHANGELOG.md's "Unreleased" section has been updated, if applicable.