Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the NSHomeDirectory on iOS #1613

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Use the NSHomeDirectory on iOS #1613

merged 1 commit into from
Oct 19, 2023

Conversation

swankjesse
Copy link
Collaborator

The NSTemporaryDirectory had similar hazards to Android's cache directory, of being evicted externally.

@squarejesse
Use the NSHomeDirectory on iOS
d039f2d 
The NSTemporaryDirectory had similar hazards to Android's
cache directory, of being evicted externally.
JakeWharton
JakeWharton approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume each app has its own UID and thus home directory?

@dnagler
Copy link
Collaborator

dnagler commented Oct 19, 2023

I assume each app has its own UID and thus home directory?

Yep:

In iOS, the home directory is the application’s sandbox directory.

dnagler
dnagler approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@dnagler dnagler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@swankjesse swankjesse merged commit c7c2440 into trunk Oct 19, 2023
8 checks passed
@swankjesse swankjesse deleted the jwilson.1018.code_cache_dir_ios branch October 19, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnagler dnagler dnagler approved these changes

@JakeWharton JakeWharton JakeWharton approved these changes

@dellisd dellisd Awaiting requested review from dellisd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swankjesse @dnagler @JakeWharton @squarejesse