Fix #814: Enhanced footer UX with separation, alignment, and responsi…#815
Open
Kuberan002 wants to merge 1 commit intocarvel-dev:developfrom
Open
Fix #814: Enhanced footer UX with separation, alignment, and responsi…#815Kuberan002 wants to merge 1 commit intocarvel-dev:developfrom
Kuberan002 wants to merge 1 commit intocarvel-dev:developfrom
Conversation
…d responsiveness
✅ Deploy Preview for carvel ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AnupmaMishra12
suggested changes
Nov 24, 2025
AnupmaMishra12
left a comment
AnupmaMishra12
left a comment
There was a problem hiding this comment.
Thanks for the PR! The footer improvements look good overall.
I noticed a few small points that could be refined:
- Duplicate
margin-topin.copywrite - Nesting of
.wrapper.footer-linksinside.bottom-links imglooks incorrect - Inline styles in
_footer.htmlcould be moved to SCSS for consistency - Consider using SCSS variables for repeated font-size and colors
I’d be happy to make these changes myself if that works for you.
Please let me know if I can push commits to this branch or open a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #814: Enhanced footer UX with separation, alignment, and responsiveness