Mention --default-label-scoping-rules CLI option#775
Open
ringerc wants to merge 1 commit intocarvel-dev:developfrom
Open
Mention --default-label-scoping-rules CLI option#775ringerc wants to merge 1 commit intocarvel-dev:developfrom
ringerc wants to merge 1 commit intocarvel-dev:developfrom
Conversation
✅ Deploy Preview for carvel canceled.
|
Mention the --default-label-scoping-rules=false CLI option, add a FAQ section about kapp's labels, and cross-link the docs in the apply section with the configuration. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
ringerc
force-pushed
the
kapp-docs-faq-labels
branch
from
8fd228d to
d10c555
Compare
Member
|
Thank you for making the docs better @ringerc! |
Contributor
Author
|
Yes, I can backport to latest stable. Will update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mention the
--default-label-scoping-rules=falseCLI option, add a FAQ section about kapp's labels, and cross-link the docs in the apply section with the configuration.I found
kapp's use of labels rather than annotations quite confusing and frustrating when I hit this bug that breakskube-prometheus's service label selector. Hopefully this will save someone else some time.May require merge with #773