Add caching mechanism for includes to optimize repetitive scans#925
Draft
WalterWoshid wants to merge 1 commit intocarthage-software:mainfrom
Draft
Add caching mechanism for includes to optimize repetitive scans#925WalterWoshid wants to merge 1 commit intocarthage-software:mainfrom
WalterWoshid wants to merge 1 commit intocarthage-software:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 What Does This PR Do?
This adds a caching mechanism for includes.
🔍 Context & Motivation
We have a lot of vendor files and running the command on a single file takes ~5 seconds with optimizations (like
threadsandstack-size). Why do we run it on single files? We don't, the Mago IDE plugin (PhpStorm) does this. When running it with the--cache-includesflag, it reduces the time to ~2 seconds. This is a huge performance boost.BUT: this is just a draft, I don't have the time to implement it cleanly, but this should be enough for someone to do it.
📂 Affected Areas
Also thanks for this awesome tool :)