Skip to content

Commit

Permalink
chore: update wrong variables and keep name patterns
Browse files Browse the repository at this point in the history
  • Loading branch information
carlohcs committed Aug 12, 2024
1 parent 6439b1a commit ca01a9c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/aws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ on:
branches:
- main
jobs:
deploy:
setup-build-publish-deploy:
name: Setup, Build, Publish, and Deploy
# Should deploy?
if: ${{ vars.DEPLOY_TO_EKS == 'true' }}
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/gc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
# TUTORIAL: https://docs.github.com/en/actions/use-cases-and-examples/deploying/deploying-to-google-kubernetes-engine

name: Build and Deploy to GKE (Google)

on:
push:
branches: [ "main" ]
branches:
- main

env:
PROJECT_ID: ${{ secrets.GKE_PROJECT }}
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Set up Cloud SDK
uses: google-github-actions/setup-gcloud@v1
with:
project_id: '${{ env.GKE_PROJECT }}'
project_id: '${{ env.PROJECT_ID }}'

- name: Docker auth
run: |-
Expand All @@ -78,6 +78,8 @@ jobs:
- name: Set up GKE credentials
uses: google-github-actions/get-gke-credentials@v0
with:
# Or only uses the full cluster_name path
# cluster_name: "projects/{project-name}/locations/{location}/clusters/{cluster-name}"
cluster_name: ${{ env.GKE_CLUSTER }}
location: ${{ env.GAR_LOCATION }}
project_id: ${{ env.PROJECT_ID }}
Expand Down

0 comments on commit ca01a9c

Please sign in to comment.