Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docusaurus from 2 to 3. #1768

Merged
merged 7 commits into from
Dec 25, 2024
Merged

Upgrade docusaurus from 2 to 3. #1768

merged 7 commits into from
Dec 25, 2024

Conversation

noonio
Copy link
Contributor

@noonio noonio commented Dec 20, 2024

This is an attempt to upgrade docurusarus in response to the baffling bug observed in https://github.com/cardano-scaling/hydra/actions/runs/12433830444/job/34716776448?pr=1715.

Todo:


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@noonio noonio changed the title Tentative upgrade attempt Tentative docusaurus upgrade attempt Dec 20, 2024
Copy link

Transaction cost differences

No cost or size differences found

Copy link

github-actions bot commented Dec 20, 2024

Transaction costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2024-12-20 23:33:28.063731325 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 00a6ddbc130ab92f5b7cb8d1ccd8d79eca5bfe25f6843c07b62841f0 2667
νCommit 3e5a776bcee213e3dfd15806952a10ac5590e3e97d09d62eb99266b2 690
νHead 8fc2a74df32d01d1db56b3acb561831ef9c9970123079423abfcb86e 12622
μHead c40e78e78083a4c137734abe9ac4070cc978842e9755fe88e0c7b922* 11133
νDeposit 2feb47889a4f658dc593cefcb0e37d584b9431944f08a687f3dab4af 4865
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per head.

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 11722 9.04 2.96 0.76
2 11919 10.63 3.46 0.79
3 12119 12.55 4.10 0.81
5 12521 15.73 5.11 0.87
10 13527 24.52 7.97 1.00
24 16341 49.13 15.96 1.38

Commit transaction costs

This uses ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 561 2.45 1.17 0.20
2 741 3.40 1.74 0.22
3 920 4.39 2.34 0.24
5 1279 6.46 3.61 0.28
10 2170 12.24 7.28 0.40
54 10065 99.20 68.72 1.89

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 560 24.83 7.22 0.43
2 114 671 32.69 9.49 0.51
3 170 782 40.39 11.72 0.60
4 228 893 52.62 15.06 0.72
5 282 1004 63.44 18.11 0.84
6 337 1116 72.54 20.66 0.93
7 395 1227 75.10 21.63 0.97
8 450 1338 97.04 27.33 1.19
9 507 1453 97.84 28.04 1.21

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 661 22.35 7.24 0.41
2 763 24.08 8.38 0.44
3 902 25.53 9.45 0.46
5 1209 28.70 11.66 0.52
10 2062 40.29 18.25 0.70
44 7096 99.44 57.54 1.68

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 674 24.43 8.03 0.44
2 801 25.90 9.17 0.46
3 914 27.50 10.34 0.49
5 1307 31.64 13.20 0.56
10 1979 39.47 19.02 0.69
43 7137 99.40 61.72 1.71

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 634 29.86 9.35 0.49
2 822 32.57 11.00 0.53
3 939 34.14 12.11 0.55
5 1201 37.75 14.56 0.61
10 2100 49.45 21.94 0.80
34 5747 99.69 54.60 1.60

Abort transaction costs

There is some variation due to the random mixture of initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 11601 25.67 8.73 0.93
2 11677 30.85 10.45 0.99
3 11758 36.25 12.22 1.05
4 12068 53.28 18.18 1.24
5 12000 53.61 18.15 1.24
6 12234 66.60 22.72 1.39
7 12256 73.71 24.94 1.46
8 12659 90.77 31.02 1.66

FanOut transaction costs

Involves spending head output and burning head tokens. Uses ada-only UTXO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
10 0 0 11715 17.34 5.93 0.85
10 1 57 11749 19.19 6.70 0.87
10 5 285 11884 25.87 9.47 0.95
10 10 569 12053 35.49 13.42 1.06
10 20 1139 12393 54.17 21.09 1.29
10 30 1706 12733 73.06 28.84 1.51
10 40 2278 13074 91.07 36.27 1.72
10 44 2502 13206 98.85 39.45 1.81

End-to-end benchmark results

This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.

Please note that these results are approximate as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.

Generated at 2024-12-20 23:36:19.452684627 UTC

Baseline Scenario

Number of nodes 1
Number of txs 300
Avg. Confirmation Time (ms) 4.857515883
P99 7.488648259999968ms
P95 6.0396202ms
P50 4.7071955ms
Number of Invalid txs 0

Three local nodes

Number of nodes 3
Number of txs 900
Avg. Confirmation Time (ms) 22.884506494
P99 41.40269061999993ms
P95 30.387643549999996ms
P50 21.2954355ms
Number of Invalid txs 0

@noonio noonio changed the title Tentative docusaurus upgrade attempt Upgrade docusaurus from 2 to 3. Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

Test Results

  5 files  ±0  162 suites  ±0   30m 49s ⏱️ -11s
556 tests ±0  550 ✅ ±0  6 💤 ±0  0 ❌ ±0 
558 runs  ±0  552 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 27d44bf. ± Comparison against base commit d271323.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
Hydra.ContestationPeriod/fromNominalDiffTime ‑ fails for diff times <= 0
Hydra.ContestationPeriod/fromNominalDiffTime ‑ works for diff times > 0
Hydra.ContestationPeriod/fromNominalDiffTime ‑ fails for diff times `<= 0`
Hydra.ContestationPeriod/fromNominalDiffTime ‑ works for diff times `> 0`

♻️ This comment has been updated with latest results.

@noonio noonio marked this pull request as ready for review December 20, 2024 23:32
@noonio noonio requested a review from a team December 20, 2024 23:32
@v0d1ch v0d1ch added this pull request to the merge queue Dec 25, 2024
Merged via the queue into master with commit 9b24239 Dec 25, 2024
27 checks passed
@v0d1ch v0d1ch deleted the upgrade-docusaurus branch December 25, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants