Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wrapper for prove, verify and param derivation. #73

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

tolikzinovyev
Copy link
Member

@tolikzinovyev tolikzinovyev commented Nov 19, 2024

Content

A simple wrapper struct around prove() and verify() functions and parameter derivation.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)

Issue(s)

Relates to #66

@tolikzinovyev tolikzinovyev marked this pull request as ready for review November 19, 2024 17:28
@tolikzinovyev tolikzinovyev self-assigned this Nov 19, 2024
@rrtoledo rrtoledo mentioned this pull request Nov 7, 2024
4 tasks
src/centralized_telescope/wrapper.rs Show resolved Hide resolved
src/centralized_telescope/wrapper.rs Show resolved Hide resolved
src/centralized_telescope/wrapper.rs Outdated Show resolved Hide resolved
src/centralized_telescope/wrapper.rs Outdated Show resolved Hide resolved
src/centralized_telescope/wrapper.rs Show resolved Hide resolved
Copy link
Collaborator

@curiecrypt curiecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @rrtoledo with the following:

  • CentralizedTelescope
  • Put warning first
  • Call the unsafe function unsafe
    I think the public function docs could be done in another pr.

@tolikzinovyev tolikzinovyev changed the title Add a wrapper for prove and verify functions. Add a wrapper for prove, verify and param derivation. Dec 2, 2024
Copy link
Collaborator

@rrtoledo rrtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tolikzinovyev tolikzinovyev merged commit 07db4a9 into main Dec 5, 2024
1 check passed
@tolikzinovyev tolikzinovyev deleted the tolik/wrapper branch December 5, 2024 18:51
curiecrypt added a commit that referenced this pull request Dec 9, 2024
## Content

This PR includes a new folder structure for centralized documentation.
Some example markdown files are created and they are linked to the
related source files.
The content will be filled out after the team approves the doc structure
and pr #66 and #73 are merged.

## Pre-submit checklist

- Branch
    - [x] Commit sequence broadly makes sense
    - [x] Key commits have useful messages
- PR
    - [x] No clippy warnings in the CI
    - [x] Self-reviewed the diff
    - [x] Useful pull request description
    - [x] Reviewer requested
- Documentation
    - [x] Update documentation website (if relevant)

## Issue(s)
Closes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants