-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a wrapper for prove, verify and param derivation. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolikzinovyev
force-pushed
the
tolik/wrapper
branch
from
November 19, 2024 17:18
96c144e
to
d0329fc
Compare
rrtoledo
requested changes
Nov 26, 2024
curiecrypt
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @rrtoledo with the following:
CentralizedTelescope
- Put warning first
- Call the unsafe function
unsafe
I think the public function docs could be done in another pr.
tolikzinovyev
force-pushed
the
tolik/wrapper
branch
from
December 2, 2024 15:11
2b9f44d
to
fbc03e4
Compare
tolikzinovyev
changed the title
Add a wrapper for prove and verify functions.
Add a wrapper for prove, verify and param derivation.
Dec 2, 2024
tolikzinovyev
force-pushed
the
tolik/wrapper
branch
from
December 3, 2024 15:43
fbc03e4
to
13160bd
Compare
rrtoledo
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
7 tasks
curiecrypt
approved these changes
Dec 5, 2024
curiecrypt
added a commit
that referenced
this pull request
Dec 9, 2024
## Content This PR includes a new folder structure for centralized documentation. Some example markdown files are created and they are linked to the related source files. The content will be filled out after the team approves the doc structure and pr #66 and #73 are merged. ## Pre-submit checklist - Branch - [x] Commit sequence broadly makes sense - [x] Key commits have useful messages - PR - [x] No clippy warnings in the CI - [x] Self-reviewed the diff - [x] Useful pull request description - [x] Reviewer requested - Documentation - [x] Update documentation website (if relevant) ## Issue(s) Closes #88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
A simple wrapper struct around
prove()
andverify()
functions and parameter derivation.Pre-submit checklist
Issue(s)
Relates to #66