-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement parameter derivation for simple lottery. #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the code is clean and good.
You have made an error on the dichotomic search lower bound and I think also the mu computation however. You could also process more quickly the case when the lambdas are equal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tolikzinovyev, the algorithm seems simple and efficient. However, we should agree on some coding style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for answering the reviews. I have commented on the opened discussions.
You adopted a very different coding style for the test, as @curiecrypt highlighted. For coherence, I would suggest to stick with one and so modify either the lottery's or the centralized lottery accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
41be680
to
ed28d52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Content
Parameter derivation for simple lottery based on section 4.1 of the paper. Uses binary search to find the optimal value of
rs
.Pre-submit checklist
Comments
Issue(s)