-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc changes #121
base: main
Are you sure you want to change the base?
Misc changes #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
One thing: I have changed the DATA_LENGTH = 48
.
However, @tolikzinovyev said: If the data length is changed, it should be done in example PRs, see.
If we go with the way that Tolik suggested, I will re-set the data length to 32. If not, you may want to update this branch :)
@@ -4,3 +4,4 @@ dist-newstyle | |||
.DS_Store | |||
target | |||
Cargo.lock | |||
docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this? docs
is committed in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that docs should be built locally and not committed
let params = Params { | ||
soundness_param: 10.0, | ||
completeness_param: 10.0, | ||
set_size: 80 * set_size / 100, | ||
lower_bound: 20 * set_size / 100, | ||
set_size: set_size.saturating_mul(80).div_ceil(100), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this trigger for you when you run clippy? I doesn't on my laptop or in CI, even though it should...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did trigger on the CI in the old PR
Rebased |
25c468d
to
514f46a
Compare
Content
This PR includes:
Pre-submit checklist
Comments
Misc changes from from former #66 and #116
Issue(s)
Relates to #59