Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - Centralized Telescope: Main #101

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Dec 12, 2024

Content

This PR includes general information about the Section 3.2.2. Generalization to small $n_p$, centralized_telescope.
The further details such as parameter setup, algorithms will be handled in individual PRs.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

Issue(s)

Closes #100

@curiecrypt curiecrypt force-pushed the curiecrypt/doc-centralized-main branch from cdee2bf to 22a9c73 Compare December 13, 2024 19:11
@curiecrypt curiecrypt marked this pull request as ready for review December 13, 2024 19:42
Copy link
Collaborator

@rrtoledo rrtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tiny changes here and there and a big one about H1 (and the order of limit bound vs expanding the tuple).

docs/rustdoc/centralized_telescope/main.md Outdated Show resolved Hide resolved
docs/rustdoc/centralized_telescope/main.md Outdated Show resolved Hide resolved
docs/rustdoc/centralized_telescope/main.md Outdated Show resolved Hide resolved
docs/rustdoc/centralized_telescope/main.md Outdated Show resolved Hide resolved
docs/rustdoc/centralized_telescope/main.md Outdated Show resolved Hide resolved
docs/rustdoc/centralized_telescope/main.md Outdated Show resolved Hide resolved
@curiecrypt curiecrypt requested a review from rrtoledo December 16, 2024 15:38
rrtoledo
rrtoledo previously approved these changes Dec 24, 2024
Copy link
Collaborator

@rrtoledo rrtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just added a couple of suggestions in core component.

Is there a particular reason why you don't include v in the sequence? E.g. "A bounded DFS search is used to construct the sequence $(t, s_1, ..., s_u)$"

docs/rustdoc/centralized_telescope/main.md Outdated Show resolved Hide resolved
docs/rustdoc/centralized_telescope/main.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - Centralized Telescope: Main
3 participants