Verifying registries and credentials #62
Conversation
src/main/java/org/cardanofoundation/signify/app/credentialing/credentials/Credentials.java
Outdated
Show resolved
Hide resolved
src/test/java/org/cardanofoundation/signify/e2e/VerifyCredentialTest.java
Outdated
Show resolved
Hide resolved
|
e2e tests failing |
yep, we wait for the new keria docker image |
updated keria image |
Sotatek-Patrick-Vu
force-pushed
the
feat/verifyCreds
branch
2 times, most recently
from
6d44b44 to
9b9a68d
Compare
This reverts commit b4be391.
Sotatek-Patrick-Vu
force-pushed
the
feat/verifyCreds
branch
from
9b9a68d to
2c2e387
Compare
src/main/java/org/cardanofoundation/signify/app/credentialing/credentials/Credentials.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cardanofoundation/signify/app/credentialing/registries/Registries.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cardanofoundation/signify/app/credentialing/credentials/Credentials.java
Outdated
Show resolved
Hide resolved
src/test/java/org/cardanofoundation/signify/e2e/VerifyCredentialTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/cardanofoundation/signify/e2e/VerifyCredentialTest.java
Outdated
Show resolved
Hide resolved
| Serder holderAcdcSerder = new Serder(acdcEvent); | ||
| Serder holderIssSerder = new Serder(issEvent); | ||
|
|
||
| Object holderCredentialVerifyOp = holderClient.credentials().verify(holderAcdcSerder, holderIssSerder, null, issAttachment); |
There was a problem hiding this comment.
Hmm, the ACDCs don't have an attachment ever? If they don't, I would remove this from the API. But we should check if there are ever cases.
There was a problem hiding this comment.
We discussed here, so I support atc for acdc But we have not used it now
https://github.com/cardano-foundation/cf-signify-java/pull/62/files/af01d93aefdb3c99f81537af2eecdc7ee5aef15f#r2428421154
There was a problem hiding this comment.
Yeah but can you check if ACDCs can have attachments? Or it's always null?
There was a problem hiding this comment.
Yes, ACDCs can have attachments but I don't need it for verifying now
| } | ||
|
|
||
| System.out.println("Completed verification of " + allVcpEvents.size() + " VCP events in the chain"); | ||
| return null; |
There was a problem hiding this comment.
Do we need the return null; statements in this file?
src/test/java/org/cardanofoundation/signify/e2e/VerifyCredentialTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/cardanofoundation/signify/e2e/VerifyCredentialTest.java
Outdated
Show resolved
Hide resolved
Sotatek-Patrick-Vu
force-pushed
the
feat/verifyCreds
branch
from
168c7fe to
0722879
Compare
No description provided.