Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-???? | NFT and Token Authentication #917

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

emir-olgun
Copy link

@emir-olgun emir-olgun commented Sep 25, 2024

Metadata Standard for using NFT and Tokens for authentication.


(rendered latest version)

@rphair rphair changed the title CIP-?: NFT and Token Authentication CIP-???? | NFT and Token Authentication Sep 25, 2024
@rphair rphair added the Category: Tokens Proposals belonging to the 'Tokens' category. label Sep 25, 2024
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emir-olgun this is a vital application that needs a solid standard for it.

Please also have a look at the method proposed in #294 (@Padierfind) - since the methods in that proposal went quite far through community review and approval before the author abandoned the document.

First you will have to follow the document structure defined in CIP-0001. It looks like you have copied the text from an old CIP but will observe that CIPs today follow a different structure, which even the older CIPs have been edited to adopt. We can review this more fully when you've made your best effort to adjust to that format: https://github.com/cardano-foundation/CIPs/blob/master/CIP-0001/README.md#document

Comment on lines +1 to +11
# CIP-?: NFT and Token Authentication

---
- **CIP**: ?
- **Title**: NFT and Token Authentication
- **Authors**: Emir Olgun <[email protected]>
- **Discussions-To**: https://github.com/littlefish-foundation/CIPs/discussions
- **Status**: Proposed
- **Created**: 2024-09-17
- **License**: CC-BY-4.0
---
Copy link
Collaborator

@rphair rphair Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# CIP-?: NFT and Token Authentication
---
- **CIP**: ?
- **Title**: NFT and Token Authentication
- **Authors**: Emir Olgun <[email protected]>
- **Discussions-To**: https://github.com/littlefish-foundation/CIPs/discussions
- **Status**: Proposed
- **Created**: 2024-09-17
- **License**: CC-BY-4.0
---
---
CIP: ?
Title: NFT and Token Authentication
Authors:
- Emir Olgun <[email protected]>
Discussions:
- https://github.com/cardano-foundation/CIPs/pull/917
Implementors: []
Status: Proposed
Created: 2024-09-17
License: CC-BY-4.0
---

The most important change (besides the wrong document structure below): this is not a human readable list, but rather a YAML metadata section: https://github.com/cardano-foundation/CIPs/blob/master/CIP-0001/README.md#header-preamble

@rphair rphair added the State: Triage Applied to new PR afer editor cleanup on GitHub, pending CIP meeting introduction. label Sep 25, 2024
@@ -0,0 +1,154 @@
# CIP-?: NFT and Token Authentication
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# CIP-?: NFT and Token Authentication

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @emir-olgun - as already suggested in #917 (comment), it's a requirement that this H1 be removed which in any case is redundant with the CIP title in the file metadata.

@rphair rphair added State: Unconfirmed Triaged at meeting but not confirmed (or assigned CIP number) yet. and removed State: Triage Applied to new PR afer editor cleanup on GitHub, pending CIP meeting introduction. labels Oct 15, 2024
@rphair
Copy link
Collaborator

rphair commented Oct 15, 2024

@emir-olgun after initial discussion of this submission at the CIP Editors' meeting today, we can't move ahead with this unless you engage about the basic format issues & try to respond about the already posted comments. Please take the above suggestions into account & otherwise this should be marked Waiting for Author soon.

@rphair rphair added State: Waiting for Author Proposal showing lack of documented progress by authors. and removed State: Unconfirmed Triaged at meeting but not confirmed (or assigned CIP number) yet. labels Nov 4, 2024
@rphair
Copy link
Collaborator

rphair commented Nov 4, 2024

@emir-olgun marking this Waiting for Author as per #917 (comment).

@rphair
Copy link
Collaborator

rphair commented Dec 16, 2024

@emir-olgun we do need you to please engage with CIP reviewers if this submission is to be kept open.

@rphair rphair added State: Likely Abandoned Close if confirmed abandoned (long waiting). and removed State: Waiting for Author Proposal showing lack of documented progress by authors. labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Tokens Proposals belonging to the 'Tokens' category. State: Likely Abandoned Close if confirmed abandoned (long waiting).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants