Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solutions for advent of code, day 4 - 13. #4750
base: trunk
Are you sure you want to change the base?
Solutions for advent of code, day 4 - 13. #4750
Changes from all commits
ebea4c3
4537b15
1121995
2dd719a
8c0de0a
70536c9
95ed965
17dd3e0
3588ec1
6ea0194
7793759
d3ff44c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth having any documentation in these files? A lot of these get fairly complex, including when you get into hex representations of characters. Where do you see the balance of maintenance and discarding if the code needs updated? (maybe it's more on the latter side, due to a lack of tests?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding documentation: while we are asked not to distribute the test inputs or the problem description, I think it'd be fine to include links to the problems. I've gone ahead and done that, but that only helps for part 1 -- the part 2 description is unavailable unless you are logged in and have solved part 1.
I've been a bit wary of including too much description in these because of the request to not distribute the problems, but perhaps I'm being too cautious. I'm intending to do some more maintenance of these examples over time (using new Carbon features as they become available, for example), and will think about striking a better balance here as I rework these.
Regarding maintenance versus discarding: I've added some instructions to
README.md
for how to react to build breaks. I'm leaning towards disabling rather than deleting the examples when they break, but I don't mind much either way; it's easy to get them back from git history if we'd prefer to delete them immediately.