Suppress testing SemIR in int builtin tests. #4748
Conversation
Add `EXTRA-ARGS:` support to file_test, to add arguments without overriding the default arguments. Use `EXTRA-ARGS: --no-dump-sem-ir` to turn off SemIR dumping and thus SemIR testing in the int builtin tests, which validate correct behavior through diagnostics instead. This doesn't get us any closer to supporting more targeted SemIR dumping / testing, but hopefully this is a generally useful feature for argument testing. Requested in review of carbon-language#4716.
| fn RuntimeCall(a: i32, b: i32) -> i32 { | ||
| return And(a, b); | ||
| } |
There was a problem hiding this comment.
The SemIR seams still useful, and the only real test we have for the runtime call case. Would it make sense to split the runtime call tests out to files that continue to dump SemIR and only skip it in the ones where we do compile time validation?
There was a problem hiding this comment.
I think the only thing this is testing that's specific to each builtin is that a runtime call is valid. Beside that, the handling is not specific to the particular builtin -- we get the same call SemIR regardless of the kind of builtin -- so I think it's probably good enough to test that only once rather than once per builtin.
To that end, I've gone ahead and added SemIR output coverage for runtime calls to toolchain/check/testdata/function/builtin/call.carbon (which previously only covered compile-time calls).
There was a problem hiding this comment.
Sure... Maybe RuntimeCallIsValid or something to make that a bit more obvious why there is nothing verified beyond that?
| fn RuntimeCall(a: i32, b: i32) -> i32 { | ||
| return And(a, b); | ||
| } |
There was a problem hiding this comment.
Sure... Maybe RuntimeCallIsValid or something to make that a bit more obvious why there is nothing verified beyond that?
Add
EXTRA-ARGS:support to file_test, to add arguments withoutoverriding the default arguments. Use
EXTRA-ARGS: --no-dump-sem-irtoturn off SemIR dumping and thus SemIR testing in the int builtin tests,
which validate correct behavior through diagnostics instead.
This doesn't get us any closer to supporting more targeted SemIR dumping
/ testing, but this seems to be a generally useful feature anyway. Most existing
tests using
ARGShave been switched over to usingEXTRA-ARGS.Requested in review of #4716.