Use unsigned arithmetic builtins for UInt(N) operations #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were mistakenly using the signed builtins, which produce the same
lowering for add/multiply right now, but don't for division and modulus.
When manually flipping SignedOverflowIsUB on, the signed version of add
gains the nsw (no signed wrap) flag, while the unsigned version
(correctly after this change) does not:
// CHECK:STDOUT: define i32 @_Cadd_i32.Main(i32 %a, i32 %b) !dbg !4 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: %int.sadd = add nsw i32 %a, %b, !dbg !7
// CHECK:STDOUT: ret i32 %int.sadd, !dbg !8
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: define i32 @_Cadd_u32.Main(i32 %a, i32 %b) !dbg !9 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: %int.uadd = add i32 %a, %b, !dbg !10
// CHECK:STDOUT: ret i32 %int.uadd, !dbg !11
// CHECK:STDOUT: }
zygoloid
approved these changes
Dec 26, 2024
| } | ||
|
|
||
| impl forall [N:! IntLiteral()] UInt(N) as Mul { | ||
| fn Op[self: Self](other: Self) -> Self = "int.smul"; | ||
| fn Op[self: Self](other: Self) -> Self = "int.umul"; | ||
| } | ||
|
|
||
| impl forall [N:! IntLiteral()] UInt(N) as Negate { | ||
| fn Op[self: Self]() -> Self = "int.snegate"; |
There was a problem hiding this comment.
Suggested change
| fn Op[self: Self]() -> Self = "int.snegate"; | |
| fn Op[self: Self]() -> Self = "int.unegate"; |
snegate traps on signed overflow (eg, -(-0x8000_0000 as i32) is an error); unegate does not. This would be visible in the overflow flags in lowering if we emitted them; for now I think it is only visible in constant evaluation.
There was a problem hiding this comment.
Fixed in #4744. (It turns out that snegate actually performed a unegate when used on an unsigned operand, so this was already functionally correct.)
There was a problem hiding this comment.
Ah yes missed that one, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mistakenly using the signed builtins, which produce the same lowering for add/multiply right now, but don't for division and modulus.
When manually flipping SignedOverflowIsUB on, the signed version of add gains the nsw (no signed wrap) flag, while the unsigned version (correctly after this change) does not: