Abort checking when encountering an invalid parse node #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
reviewed
Dec 17, 2024
| @@ -346,6 +346,11 @@ auto CheckUnit::ProcessNodeIds() -> bool { | |||
| node_id = *maybe_node_id; | |||
| auto parse_kind = context_.parse_tree().node_kind(node_id); | |||
|
|
|||
| if (context_.parse_tree().node_has_error(node_id)) { | |||
| context_.TODO(node_id, "handle invalid parse trees in `check`"); | |||
There was a problem hiding this comment.
Where this causes code to no longer be reached, would it be worth switching to CARBON_FATAL?
e.g.:
- HandleInvalidParse (and variants)
- The pre-existing TODOs for "Error recovery from keyword name"
(for contrast, valid code encounters "function with positional parameters", you're only removing 1 case of 4)
There was a problem hiding this comment.
Ah, yep - done.
I did change the "Error recovery from keyword name" to CARBON_CHECK since otherwise they'd be branch-to-unreachable (which is disfavorable in the LLVM style, at least) - happy to switch back to CARBON_FATAL if it makes more sense in this particular case.
There was a problem hiding this comment.
Makes sense to CHECK where it fits.
jonmeow
approved these changes
Dec 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like a check_fuzzer timeout, just flaky. (another run took 3s, so some abnormal issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short term solution/block for #4689