Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch TypeId::TypeType to TypeType::SingletonTypeId, and similar #4619

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Switch TypeId::TypeType to TypeType::SingletonTypeId, and similar #4619

merged 1 commit into from
Dec 4, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Dec 3, 2024 •
edited
Loading

ids.h and ids.cpp are the manual edits, everything else is search-and-replace.

The full list of things moved is:

  • TypeId::TypeType
  • TypeId::AutoType
  • TypeId::Error
  • ConstantId::Error

This is to unblock removing InstId::Builtin*.

@github-actions github-actions bot requested a review from geoffromer December 3, 2024 21:20
@geoffromer geoffromer enabled auto-merge December 4, 2024 00:02
@geoffromer geoffromer disabled auto-merge December 4, 2024 00:03
@jonmeow jonmeow enabled auto-merge December 4, 2024 18:29
@jonmeow jonmeow added this pull request to the merge queue Dec 4, 2024
Merged via the queue into carbon-language:trunk with commit 0e92e6c Dec 4, 2024
8 checks passed
@jonmeow jonmeow deleted the singleton-type-id branch December 4, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffromer geoffromer geoffromer approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @geoffromer