Factor out machinery for forming int type literals. #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use it in the remaining few places where we currently hardcode `i32`: as the index type in array indexing, as the type for literals in `if` expressions, and as a valid return type for `Run`. In preparation for changing `Core.Int` to be a class.
jonmeow
approved these changes
Dec 3, 2024
Co-authored-by: Jon Ross-Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it in the remaining few places where we currently hardcode
i32: as the index type in array indexing, as the type for literals inifexpressions, and as a valid return type forRun.In preparation for changing
Core.Intto be a class.