-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facet types support rewrite (where .A =
...) constraints
#4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Dec 3, 2024
Co-authored-by: Richard Smith <[email protected]>
zygoloid
approved these changes
Dec 3, 2024
josh11b
added a commit
to josh11b/carbon-lang
that referenced
this pull request
Dec 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Issue was not properly handling `ImportRef` instructions in `AddAssociatedEntities` in `check/import_ref.cpp`. Using `CARBON_CHECK` instead of `CARBON_FATAL` was hiding the error. --------- Co-authored-by: Josh L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.Self
from other symbolic bindings in two ways:.Self
itself now has an invalid compile time binding index (since it doesn't bind to any of the generic parameters). As a result, we no longer need to create a generic region inhandle_where.cpp
..Self
. This allows us to give the result of awhere
expression template phase as long as it doesn't use any symbolic constants other than.Self
or other designators.AddConstant
has been removed fromcheck/context
since it was only used fromeval
. This meant less plumbing of the phase change.BindSymbolicName
now also performs substitution into its type.StringifyTypeExpr
outputs rewrites, which required adding support for associated entities as well..Self
mixed with other symbolic constants.Still to do: