Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook Playground and Stackblitz #18250

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Dec 12, 2024

Closes #16816

Storybook does not offer a good integration with third party packages like @stackblitz/sdk. There is no clean way to grab code from stories, that's why the codePreviewer.tsx file has a lot of regex.

We are gonna add the "Open in Stackblitz" option in this issue.

Changelog

  • Added the @stackblitz/sdk package. With this package now we are able to add an "Open in Stackblitz" for components.

Changed

  • Added args to stories that make sense to use it.
  • Changed avt tests to match the new story name.

Removed

  • Removed the Playground stories from 99% os components.

Testing / Reviewing

  • Verify if the stories are working as expected.
  • Percy with throw a few "errors" as expected. We can use that to review those specific components.

@guidari guidari requested a review from a team as a code owner December 12, 2024 15:28
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 60b4f31
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/675c75d6a8a0e200087a0905
😎 Deploy Preview https://deploy-preview-18250--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 60b4f31
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/675c75d6b3b88d0008cbaebf
😎 Deploy Preview https://deploy-preview-18250--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 60b4f31
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/675c75d6983c070008405a87
😎 Deploy Preview https://deploy-preview-18250--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/react/previewer/codePreviewer.tsx Dismissed Show dismissed Hide dismissed
packages/react/previewer/codePreviewer.tsx Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (812d029) to head (60b4f31).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18250   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         404      404           
  Lines       14352    14352           
  Branches     4601     4655   +54     
=======================================
  Hits        12101    12101           
+ Misses       2090     2089    -1     
- Partials      161      162    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise "Playground" story approach in the @carbon/react storybook
1 participant