Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to react v19 #18207

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Dec 5, 2024

Closes #16282
Closes #16620

Changelog

Changed

  • update deps to react v19
  • update peer dep ranges to include 19

Testing / Reviewing

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a0d6707
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6758ae0ccde45d000960ce71
😎 Deploy Preview https://deploy-preview-18207--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 58210ed
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6761e5a214e2370008cd6149
😎 Deploy Preview https://deploy-preview-18207--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 57c3440
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67521bfb492d9000087021c9
😎 Deploy Preview https://deploy-preview-18207--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit a0d6707
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6758ae0c1399770008506df6
😎 Deploy Preview https://deploy-preview-18207--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (a022b9a) to head (a0d6707).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18207   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files         404      404           
  Lines       14350    14350           
  Branches     4619     4653   +34     
=======================================
  Hits        12077    12077           
  Misses       2111     2111           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just need to resolve the conflict in package.json with "@types/react-is" and "accessibility-checker" versions!

@tay1orjones
Copy link
Member Author

@emyarod Updated, thanks! Also realized I forgot to update resolutions in the root package.json, so that's fixed too.

@tay1orjones tay1orjones requested a review from emyarod December 13, 2024 17:27
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod
Copy link
Member

emyarod commented Dec 13, 2024

reran the test job since it was failing on an icon build

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess after fixing the conflict it will work!

@tay1orjones
Copy link
Member Author

Updating the types has caused a bunch of additional errors to work through.

@TannerS
Copy link
Contributor

TannerS commented Dec 19, 2024

Hello, curious, is there some target deadline ti finish? also is there some report of how many components are broken with 19? thanks yall!

@jperez-paramo
Copy link

Hi all! Right now I'm upgrading my project to react 19 and I had some dependency tree problems running npm i 'cause last version of carbon doesn't support it (of course you know it jeje) do you know when this PR could be merged? thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚦 In Review
Development

Successfully merging this pull request may close these issues.

[Bug]: (Tabs) React 19 not rendering TabList items React 19 support ☂️
7 participants