-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update to react v19 #18207
base: main
Are you sure you want to change the base?
chore(deps): update to react v19 #18207
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18207 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 404 404
Lines 14350 14350
Branches 4619 4653 +34
=======================================
Hits 12077 12077
Misses 2111 2111
Partials 162 162 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just need to resolve the conflict in package.json
with "@types/react-is" and "accessibility-checker" versions!
@emyarod Updated, thanks! Also realized I forgot to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
reran the test job since it was failing on an icon build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess after fixing the conflict it will work!
fa121c0
to
7b5dba2
Compare
Updating the types has caused a bunch of additional errors to work through. |
Hello, curious, is there some target deadline ti finish? also is there some report of how many components are broken with 19? thanks yall! |
Hi all! Right now I'm upgrading my project to react 19 and I had some dependency tree problems running |
Closes #16282
Closes #16620
Changelog
Changed
Testing / Reviewing
Is the problem in [Bug]: (Tabs) React 19 not rendering TabList items #16620 still present here?